Use Generation instead of ResourceVersion when computing the cache key #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/rds/v1beta1/clusterroleassociation.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The provider cache manager currently uses
ProviderConfig.ResourceVersionwhen computing the cache keys. This PR changes it toProviderConfig.Generationso that only ProviderConfig'sspecupdates will invalidate cache entries.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Validated the PR using the package
index.docker.io/ulucinar/provider-aws-iam:v1.3.0-8dbbc58fbd82da76ef5f8f50c34aa75494964bbdand by modifying thespecof theProviderConfig. Also via uptest here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8470828375