Use crossplane/build submodule
#1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
force-pushed
the
its-happening-dot-gif
branch
from
5c449f5 to
874c608
Compare
|
/test-examples="examples/iam/v1beta1/role.yaml" |
Signed-off-by: Nic Cope <nicc@rk0n.org>
I updated these target names in the build submodules, since they're not really vendoring anything anymore (that name predates Go modules). This alias works around the need to update CI definitions in a different repo. Signed-off-by: Nic Cope <nicc@rk0n.org>
The crossplane/build submodule no longer uses UXP. Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
force-pushed
the
its-happening-dot-gif
branch
from
4313b13 to
38fe271
Compare
negz
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
|
/test-examples="examples/iam/v1beta1/role.yaml" |
jeanduplessis
approved these changes
May 16, 2024
2 tasks
tchinmai7
added a commit
to linode/provider-linode
that referenced
this pull request
May 28, 2024
Bump to latest upjet 1.4.0 Introduce a API call counter middleware to count api requests, grouped by URL and method bump go version to 1.22 Use crossplane/build instead of upbound/build - see Use crossplane/build submodule crossplane-contrib/provider-upjet-aws#1313 Set user-agent for requests to the linode api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
See crossplane/crossplane#1583 for context.
It seems like this passes CI, and uptest works. I think the only notable change is that uptest is now going to run tests using regular Crossplane, not UXP.
If this PR looks good, I'll proceed to update:
I don't think I can update every Upjet provider myself, but I'm happy to open PRs to update one or two additional popular Upjet-based providers if you have suggestions.
I have:
Runmake reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
CI and uptest both work against this PR.