Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure EndpointAccess.redshift resource and add example #1314

Merged

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented May 20, 2024

Description of your changes

This PR includes configuring the EndpointAccess.redshift resource and adding the example manifest.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9407695171

Manual test results:
Screenshot 2024-05-20 at 19 03 39

@turkenf
Copy link
Collaborator Author

turkenf commented May 20, 2024

/test-examples="examples/redshift/v1beta1/endpointaccess.yaml"

1 similar comment
@turkenf
Copy link
Collaborator Author

turkenf commented May 20, 2024

/test-examples="examples/redshift/v1beta1/endpointaccess.yaml"

Copy link
Collaborator

@mbbush mbbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are all minor. For the most part this LGTM.

examples/redshift/v1beta1/endpointaccess.yaml Outdated Show resolved Hide resolved
examples/redshift/v1beta1/endpointaccess.yaml Outdated Show resolved Hide resolved
examples/redshift/v1beta1/endpointaccess.yaml Show resolved Hide resolved
turkenf added 2 commits June 6, 2024 23:19
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf force-pushed the add-redshift-endpoint-access branch from b76e566 to 318cb5a Compare June 6, 2024 20:19
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Jun 6, 2024

/test-examples="examples/redshift/v1beta1/endpointaccess.yaml"

@turkenf turkenf merged commit d529e08 into crossplane-contrib:main Jun 6, 2024
12 checks passed
@turkenf turkenf deleted the add-redshift-endpoint-access branch June 6, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants