CodeGuru Profiler Profiling Group #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @chlunde, Thank you for opening this PR, I took a quick look at your PR:
|
|
@turkenf thanks for looking at the draft, I just pushed it to sync between two computers and didn't have time to test it yet :) But with IdentifierFromProvider and the following example: apiVersion: codeguruprofiler.aws.upbound.io/v1beta1
kind: ProfilingGroup
metadata:
annotations:
meta.upbound.io/example-id: codeguruprofiler/v1beta1/profilinggroup
labels:
testing.upbound.io/example-name: example
name: example
spec:
forProvider:
agentOrchestrationConfig:
- profilingEnabled: true
computePlatform: Default
name: example2
region: us-west-2I get If I use the code as the PR is now, it works fine: 
|
|
@turkenf should we do something about the array here? |
chlunde
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
|
@turkenf I rebased the PR due to conflict. If I try diff --git a/config/externalname.go b/config/externalname.go
index b51b69f2e..16b93fdb5 100644
--- a/config/externalname.go
+++ b/config/externalname.go
@@ -70,7 +70,7 @@ var TerraformPluginFrameworkExternalNameConfigs = map[string]config.ExternalName
// CodeGuru Profiler
// Profiling Group can be imported using the profiling group name
- "aws_codeguruprofiler_profiling_group": config.NameAsIdentifier,
+ "aws_codeguruprofiler_profiling_group": config.IdentifierFromProvider,
}
// TerraformPluginSDKExternalNameConfigs contains all external name configurationsAnd the following managed resource (with added spec.forProvider.name), it fails: apiVersion: codeguruprofiler.aws.upbound.io/v1beta1
kind: ProfilingGroup
metadata:
annotations:
meta.upbound.io/example-id: codeguruprofiler/v1beta1/profilinggroup
labels:
testing.upbound.io/example-name: example
name: example
spec:
forProvider:
name: example3
agentOrchestrationConfig:
- profilingEnabled: true
computePlatform: Default
region: us-west-2The code as it is in this PR seems to work fine, as you can see in the screenshot. Am I missing something here? |
|
/test-examples="examples/codeguruprofiler/v1beta1/profilinggroup.yaml" |
|
Hi @chlunde, The |
|
@turkenf Thanks! Sorry for the late reply, I've been traveling. I had to rebase due to conflicts. I also added |
|
/test-examples="examples/codeguruprofiler/v1beta1/profilinggroup.yaml" |
Actually, you are right @chlunde, I misunderstood the situation here 🤦 I suggested the
After this enlightenment, I think it is more appropriate to use Sorry for the misunderstanding, if you don't mind, could you please set the external name configuration to |
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
|
@turkenf cool! I've updated (and retested) |
|
/test-examples="examples/codeguruprofiler/v1beta1/profilinggroup.yaml" |
turkenf
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #959
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
A successful uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9398769793