Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce linter concurrency to 1 #1324

Merged
merged 1 commit into from
May 24, 2024

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented May 24, 2024

Description of your changes

While bumping the underlying Terraform provider version, we've observed failing linter runs. This is probably caused by the changing dependencies and the invalidation of the linter cache. We had previously observed a similar situation when working with the linter in the release-0.47 branch, and we had applied more aggressive parameters in #1217. This PR copies some of those parameters to the main branch.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Via make lint runs and in #1217.

@ulucinar ulucinar marked this pull request as draft May 24, 2024 07:56
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar changed the title [DO NOT MERGE] Linter check Reduce linter concurrency to 1 May 24, 2024
@ulucinar ulucinar marked this pull request as ready for review May 24, 2024 08:57
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 9c3df41 into crossplane-contrib:main May 24, 2024
11 checks passed
@ulucinar ulucinar deleted the linter-check branch May 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants