Bump upjet to v1.4.0 #1325
Merged
Bump upjet to v1.4.0 #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate secret references for the sensitive fields under the spec.initProdier API trees. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…der.user is not specified - Move spec.forProvider.user of the Broker.mq dependency to spec.initProvider.user in the User.mq example manifest. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/mq/v1alpha1/user.yaml" |
|
/test-examples="examples/eks/v1beta1/clusterauth.yaml" |
|
/test-examples="examples/budgets/v1beta1/budget.yaml" |
|
/test-examples="examples/iot/v1beta1/policy.yaml" |
sergenyalcin
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related with: #1311
This PR bumps the upjet dependency to
v1.4.0and generates the secret references underspec.initProviderAPI trees for the sensitive MR parameters.spec.forProvider.userof theBroker.mqdependency is moved tospec.initProvider.userin theUser.mqexample manifest to ignore the desired set of broker users declared via theBroker.mqMR and to prevent a race between theBroker.mq&User.mqcontrollers on the (external) broker users. We now also do a late-initialization configuration forspec.forProvider.userofBroker.mqso that it will be late-initialized iff thespec.initProvider.useris not set. This configuration is done to prevent an "unintended" race condition between the aforementioned controllers in cases where the client of theBroker.mqAPI deliberately disables broker user lifecycle management by only settingspec.initProvider.userand leavingspec.forProvider.userunset.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
User.v1alpha1.mqhas been registered here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9223380910/ClusterAuth.ekshas been registered here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9223465142/Budget.budgetshas been registered here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9223714803Policy.iothas been registered here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9223739185