Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): fix late init for rds clusterinstance #1326

Merged
merged 1 commit into from
May 24, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented May 24, 2024

Description of your changes

  • fix a few late init problems with rds clusterinstance

After upgrading the Version in the Cluster the ClusterInstance gets stuck in an update-loop because of the engineVersion
spec.forProvider.engineVersion

2024-05-15T14:49:54Z    DEBUG    provider-aws    Diff detected    {"uid": "31f30f84-59ed-4720-ad3a-93aae50eb27d", "name": "xxx", "gvk": "rds.aws.upbound.io/v1beta1, Kind=ClusterInstance", "instanceDiff": "*terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff{\"engine_version\":*terraform.ResourceAttrDiff{Old:\"15.5\", New:\"15.4\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, RawConfig:cty.NilVal, RawState:cty.NilVal, RawPlan:cty.NilVal, Meta:map[string]interface {}(nil)}"}
2024-05-15T14:49:54Z    DEBUG    provider-aws    Successfully requested update of external resource    {"controller": "managed/rds.aws.upbound.io/v1beta1, kind=clusterinstance", "request": {"name":"xxx"}, "uid": "31f30f84-59ed-4720-ad3a-93aae50eb27d", "version": "15401705", "external-name": "xxx", "requeue-after": "2024-05-15T15:00:05Z"}

spec.forProvider.dbParameterGroupName

The parameter group default.aurora-postgresql15 with DBParameterGroupFamily aurora-postgresql15 can't be used for this instance. Use a parameter group with DBParameterGroupFamily aurora-postgresql16.

spec.forProvider.preferredBackupWindow

The requested DB Instance will be a member of a DB Cluster. Set backup window for the DB Cluster.",

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

--- PASS: kuttl (1339.64s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1338.83s)
PASS
13:31:56 [ OK ] running automated tests

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9223450840

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
Copy link
Member Author

/test-examples="examples/rds/v1beta1/clusterinstance.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri, lgtm.

@turkenf turkenf merged commit 5df2fd2 into crossplane-contrib:main May 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants