Fix AccessKey.iam reconciliation #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the MR API has a spec.forProvider.status field and there are sensitive attributes, then fieldpath.Paved.ExpandWildcards complains instead of expanding as an empty slice, which breaks the reconciliation. - This PR consumes the upjet fix that restores the old behavior. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
changed the title
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/iam/v1beta1/accesskey.yaml" |
3 tasks
|
/test-examples="examples/mq/v1alpha1/user.yaml" |
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
/test-examples="examples/iam/v1beta1/accesskey.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related issue: crossplane/upjet#416
Depends on: crossplane/upjet#417
If the MR API has a
spec.forProvider.statusfield and there are sensitive attributes, thenfieldpath.Paved.ExpandWildcardscomplains instead of expanding as an empty slice, which breaks the reconciliation.Please refer to crossplane/upjet#417 for more context on the issue.
This PR bumps upjet to
v1.4.1.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
AccessKey.iamnow successfully reconciles and its connection details secret contains all the keys from thev1.4.0version of the provider:attribute.secret,attribute.ses_smtp_password_v4,password,usernamespec.initProviderbehavior is not broken with the uptest run ofUser.mqresource here: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9399082530