Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codeartifact resources #1368

Merged
merged 12 commits into from
Jun 24, 2024

Conversation

stevendborrelli
Copy link
Contributor

@stevendborrelli stevendborrelli commented Jun 17, 2024

Description of your changes

Adds AWS CodeArtifact resources.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

All resources tested in uptest https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9618965896

Local run for Repository/Domain/RepositoryPermissionsPolicy:

kubectl get -f rpp.yaml 
NAME                                                                                                 SYNCED   READY   EXTERNAL-NAME                                                                                                                                      AGE
repositorypermissionspolicy.codeartifact.aws.upbound.io/repositorypermissionspolicy-example-policy   True     True    arn:aws:codeartifact:us-east-1:609897127049:repository/repositorypermissionspolicy-example-domain/repositorypermissionspolicy-example-repository   35s

NAME                                                                            SYNCED   READY   EXTERNAL-NAME                                AGE
domain.codeartifact.aws.upbound.io/repositorypermissionspolicy-example-domain   True     True    repositorypermissionspolicy-example-domain   34s

NAME                                                                                    SYNCED   READY   EXTERNAL-NAME                                    AGE
repository.codeartifact.aws.upbound.io/repositorypermissionspolicy-example-repository   True     True    repositorypermissionspolicy-example-repository   34s

Local run for Domain/DomainPolicy:

NAME                                                                                  SYNCED   READY   EXTERNAL-NAME                                                                        AGE
domainpermissionspolicy.codeartifact.aws.upbound.io/domainpermissionspolicy-example   True     True    arn:aws:codeartifact:us-east-1:609897127049:domain/domainpermissionspolicy-example   10s

NAME                                                                 SYNCED   READY   EXTERNAL-NAME                     AGE
domain.codeartifact.aws.upbound.io/domainpermissionspolicy-example   True     True    domainpermissionspolicy-example   10s

stevendborrelli and others added 4 commits June 14, 2024 17:51
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domain.yaml"

Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domain.yaml,examples/codeartifact/v1beta1/respository.yaml"

@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml,examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml"

Signed-off-by: Steven Borrelli <steven@upbound.io>
@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml"

Signed-off-by: Steven Borrelli <steven@upbound.io>
@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml"

config/externalname.go Outdated Show resolved Hide resolved
Signed-off-by: Steven Borrelli <steven@upbound.io>
@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml,examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/codeartifact/v1beta1/domain.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/codeartifact/v1beta1/repository.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort in adding these resources @stevendborrelli, I left a few comments about ExtractParamPath function for you to consider.

If this function works for us, I would prefer to continue with ExtractParamPath. You can ignore my comments if you have already tried it and it did not work.

apis/codeartifact/v1beta1/reference.go Outdated Show resolved Hide resolved
config/codeartifact/config.go Outdated Show resolved Hide resolved
config/codeartifact/config.go Outdated Show resolved Hide resolved
config/codeartifact/config.go Outdated Show resolved Hide resolved
config/codeartifact/config.go Outdated Show resolved Hide resolved
@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domain.yaml,examples/codeartifact/v1beta1/respository.yaml"

@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml"

@stevendborrelli
Copy link
Contributor Author

/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/codeartifact/v1beta1/repository.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stevendborrelli, LGTM.

@turkenf turkenf merged commit e4b8f22 into crossplane-contrib:main Jun 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants