-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codeartifact resources #1368
Add Codeartifact resources #1368
Conversation
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
/test-examples="examples/codeartifact/v1beta1/domain.yaml" |
Signed-off-by: Steven Borrelli <steven@upbound.io>
Signed-off-by: Steven Borrelli <steven@upbound.io>
/test-examples="examples/codeartifact/v1beta1/domain.yaml,examples/codeartifact/v1beta1/respository.yaml" |
/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml,examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml" |
Signed-off-by: Steven Borrelli <steven@upbound.io>
/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml" |
Signed-off-by: Steven Borrelli <steven@upbound.io>
/test-examples="examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml" |
Signed-off-by: Steven Borrelli <steven@upbound.io>
/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml,examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml" |
/test-examples="examples/codeartifact/v1beta1/domain.yaml" |
/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml" |
/test-examples="examples/codeartifact/v1beta1/repository.yaml" |
/test-examples="examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort in adding these resources @stevendborrelli, I left a few comments about ExtractParamPath
function for you to consider.
If this function works for us, I would prefer to continue with ExtractParamPath
. You can ignore my comments if you have already tried it and it did not work.
Signed-off-by: Steven Borrelli <steven@upbound.io>
/test-examples="examples/codeartifact/v1beta1/domain.yaml,examples/codeartifact/v1beta1/respository.yaml" |
/test-examples="examples/codeartifact/v1beta1/repositorypermissionspolicy.yaml" |
/test-examples="examples/codeartifact/v1beta1/domainpermissionspolicy.yaml" |
/test-examples="examples/codeartifact/v1beta1/repository.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @stevendborrelli, LGTM.
Description of your changes
Adds AWS CodeArtifact resources.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
All resources tested in uptest https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9618965896
Local run for Repository/Domain/RepositoryPermissionsPolicy:
Local run for Domain/DomainPolicy: