Configure ResourcePolicy.dynamodb resource and add example #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fatih Türken <turkenf@gmail.com>
|
/test-examples="examples/dynamodb/v1beta1/resourcepolicy.yaml" |
3 tasks
mergenci
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Thanks @turkenf. LGTM. I would like to note here that we discussed off-channel how IdentifierFromProvider external-name configuration doesn't seem to work for Terraform Plugin Framework resources, as @mbbush explained. Currently, we have separate custom external-name configurations for each resource. At some point, as the number of plugin framework resources increases, we might want to invent one external-name config to rule them all 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR configures
ResourcePolicy.dynamodbresource and adds an example.Fixes #1307
Thanks to @ShayYannay for the previous PR and @mbbush for the review.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
A successful uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9845977260/job/27182735025