Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure the Environment.mwaa resource and add an example #1395

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Jul 10, 2024

Description of your changes

This PR adds aws_mwaa_environment resource.

Fixes #1093

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually:

NAME                                                       SYNCED   READY   EXTERNAL-NAME              AGE
environment.mwaa.aws.upbound.io/example-environment-test   True     True    example-environment-test   3h1m
Screenshot 2024-07-10 at 15 18 12

Uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9882342716

@turkenf turkenf mentioned this pull request Jul 10, 2024
3 tasks
@turkenf
Copy link
Collaborator Author

turkenf commented Jul 10, 2024

/test-examples="examples/mwaa/v1beta1/environment.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 10, 2024

/test-examples="examples/mwaa/v1beta1/environment.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 10, 2024

As far as I can see from the logs, the import test of some dependent resources failed due to the id change. That's why I disable the import test of resources other than the Environment.mwaa resource.

@turkenf
Copy link
Collaborator Author

turkenf commented Jul 10, 2024

/test-examples="examples/mwaa/v1beta1/environment.yaml"

sanhaKimVics and others added 5 commits July 11, 2024 01:23
Signed-off-by: sanhaKimVics <sanha.kim@vicsnc.com>
Signed-off-by: sanhaKimVics <sanha.kim@vicsnc.com>
Signed-off-by: sanhaKimVics <sanha.kim@vicsnc.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf turkenf marked this pull request as ready for review July 10, 2024 22:27
@turkenf
Copy link
Collaborator Author

turkenf commented Jul 10, 2024

/test-examples="examples/mwaa/v1beta1/environment.yaml"

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf. LGTM.

@turkenf turkenf merged commit a144a48 into crossplane-contrib:main Jul 11, 2024
12 checks passed
@turkenf turkenf deleted the issue-1093 branch July 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MWAA Environments (AWS Managed Airflow)
3 participants