Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(late-init): add late-init skips for v1beta1 #1417

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jul 24, 2024

Description of your changes

followup for #1374 and #1377

@ulucinar in chat: upjet currently does not generate the older versions, it generates only the latest version. We need to manually maintain the older versions.

Fixes #1415

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10074958060

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@turkenf
Copy link
Collaborator

turkenf commented Jul 24, 2024

/test-examples="examples/ec2/v1beta1/launchtemplate.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @haarchri, LGTM.

@turkenf turkenf merged commit 7fc9c8d into crossplane-contrib:main Jul 24, 2024
12 checks passed
Copy link

Successfully created backport PR #1424 for release-1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: upjet LateInitializer ignoredFields missing generation in older api versions
2 participants