-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Terraform provider version to v5.68.0 #1513
Conversation
5a4d603
to
2dffd56
Compare
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
/test-examples="examples/elasticache/v1beta1/replicationgroup.yaml" |
/test-examples="examples/firehose/v1beta1/deliverystream.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
a9386a2
to
8d29292
Compare
/test-examples="examples/rds/v1beta1/instance.yaml" |
/test-examples="examples/firehose/v1beta1/deliverystream.yaml" |
/test-examples="examples/appsync/v1beta1/graphqlapi.yaml" |
/test-examples="examples/elasticache/v1beta1/replicationgroup.yaml" |
/test-examples="examples/eks/v1beta1/cluster.yaml" |
/test-examples="examples/ecs/v1beta1/cluster.yaml" |
/test-examples="examples/dynamodb/v1beta1/table.yaml" |
/test-examples="examples/elbv2/v1beta1/lblistener.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
/test-examples="examples/elbv2/v1beta1/lblistener.yaml" |
/test-examples="examples/firehose/v1beta1/deliverystream.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @turkenf, for not letting mistakes go unnoticed 🙏
For future reference, our makeshift script that converts backported embedded object fields into singleton lists doesn't work if Terraform resource name (aws_lb_listener
) doesn't agree with our types-file path (apis/elbv2/v1beta1/zz_lblistener_types.go
). It assumes that the Terraform resource name could be built out of the path (aws_elbv2_lb_listener
), hence the last commit in the PR.
Let's also note that the failing Uptest for LBListener is a known issue: #1352
Description of your changes
In this PR:
Upgraded Terraform provider version to
v5.68.0
I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Breaking CRD schema changes
package/crds/ecs.aws.upbound.io_services.yaml
=> Manually tested, see ecs:Service
Resource in a constant update loop #585package/crds/elasticache.aws.upbound.io_replicationgroups.yaml
=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11243202692package/crds/firehose.aws.upbound.io_deliverystreams.yaml
=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11243215011Native schema version changes
aws_ecs_service
=> Manually tested, see ecs:Service
Resource in a constant update loop #585