Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform provider version to v5.68.0 #1513

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Oct 8, 2024

Description of your changes

In this PR:

Upgraded Terraform provider version to v5.68.0

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Breaking CRD schema changes

Native schema version changes

@turkenf turkenf force-pushed the bump-tf-5.68.0 branch 2 times, most recently from 5a4d603 to 2dffd56 Compare October 8, 2024 19:33
@turkenf
Copy link
Collaborator Author

turkenf commented Oct 8, 2024

/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 8, 2024

/test-examples="examples/elasticache/v1beta1/replicationgroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 8, 2024

/test-examples="examples/firehose/v1beta1/deliverystream.yaml"

@mergenci mergenci marked this pull request as ready for review October 10, 2024 22:56
turkenf and others added 6 commits October 11, 2024 11:07
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/rds/v1beta1/instance.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/firehose/v1beta1/deliverystream.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/appsync/v1beta1/graphqlapi.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/elasticache/v1beta1/replicationgroup.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/eks/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/ecs/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/dynamodb/v1beta1/table.yaml"

@mergenci
Copy link
Collaborator

/test-examples="examples/elbv2/v1beta1/lblistener.yaml"

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/elbv2/v1beta1/lblistener.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 11, 2024

/test-examples="examples/firehose/v1beta1/deliverystream.yaml"

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @turkenf, for not letting mistakes go unnoticed 🙏

For future reference, our makeshift script that converts backported embedded object fields into singleton lists doesn't work if Terraform resource name (aws_lb_listener) doesn't agree with our types-file path (apis/elbv2/v1beta1/zz_lblistener_types.go). It assumes that the Terraform resource name could be built out of the path (aws_elbv2_lb_listener), hence the last commit in the PR.

Let's also note that the failing Uptest for LBListener is a known issue: #1352

@turkenf turkenf merged commit 4407f96 into crossplane-contrib:main Oct 11, 2024
12 of 13 checks passed
@turkenf turkenf deleted the bump-tf-5.68.0 branch October 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants