Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving operationalinsights (7), portal (1) resources to v1beta1 version #205

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Moving operationalinsights (7), portal (1) resources to v1beta1 version #205

merged 1 commit into from
Jan 25, 2023

Conversation

svscheg
Copy link
Contributor

@svscheg svscheg commented Jan 23, 2023 •
edited
Loading

Description of your changes

Moving operationalinsights (7) resources to v1beta1 version

Moving portal (1) resources to v1beta1 version

Fixes #167

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually
Uptests

dverveiko
dverveiko reviewed Jan 23, 2023
View reviewed changes
examples/operationalinsights/loganalyticslinkedservice.yaml Outdated
kind: Account
metadata:
annotations:
meta.upbound.io/example-id: automation/v1beta1/account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta.upbound.io/example-id: automation/v1beta1/account
meta.upbound.io/example-id: operationalinsights/v1beta1/loganalyticslinkedservice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@svscheg svscheg force-pushed the operationalinsights_portal branch 5 times, most recently from 4ad50c5 to 5336bae Compare January 23, 2023 12:22
@svscheg
Copy link
Contributor Author

svscheg commented Jan 23, 2023

/test-examples="examples/portal/dashboard.yaml"

@svscheg svscheg force-pushed the operationalinsights_portal branch 2 times, most recently from 2f06702 to e3d37ef Compare January 23, 2023 17:29
@svscheg
Copy link
Contributor Author

svscheg commented Jan 23, 2023

/test-examples="examples/portal/dashboard.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 23, 2023

/test-examples="examples/operationsmanagement/loganalyticssolution.yaml"

@svscheg svscheg force-pushed the operationalinsights_portal branch 4 times, most recently from 2262d4d to 3ac65c1 Compare January 24, 2023 07:15
@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/portal/dashboard.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationsmanagement/loganalyticssolution.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/portal/dashboard.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationsmanagement/loganalyticssolution.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdataexportrule.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdatasourcewindowsevent.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdatasourcewindowsperformancecounter.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdatasourcewindowsevent.yaml"

1 similar comment
@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdatasourcewindowsevent.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationsmanagement/loganalyticssolution.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdataexportrule.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticsdatasourcewindowsperformancecounter.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticslinkedservice.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticslinkedstorageaccount.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticssavedsearch.yaml"

@svscheg
Copy link
Contributor Author

svscheg commented Jan 24, 2023

/test-examples="examples/operationalinsights/loganalyticssavedsearch.yaml"

sergenyalcin
sergenyalcin approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svscheg LGTM!

@svscheg svscheg merged commit d1e0bf6 into crossplane-contrib:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dverveiko dverveiko dverveiko left review comments

@sergenyalcin sergenyalcin sergenyalcin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving operationalinsights (7), portal (1) resources to v1beta1 version
3 participants
@svscheg @sergenyalcin @dverveiko