Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding datafactory(19) resources #231

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Adding datafactory(19) resources #231

merged 1 commit into from
Jan 26, 2023

Conversation

kdibrov
Copy link
Contributor

@kdibrov kdibrov commented Jan 25, 2023 •
edited
Loading

Description of your changes

Fixes #222
Moving 19 resources from datafactory group:

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually:
azurerm_data_factory_linked_service_kusto - requires KustoDb Principal Assignment with real objectId and tenantId
kusto_linked

Uptest:
azurerm_data_factory_linked_service_azure_databricks
azurerm_data_factory_linked_service_azure_file_storage
azurerm_data_factory_linked_service_azure_function
azurerm_data_factory_linked_service_azure_search
azurerm_data_factory_linked_service_azure_sql_database
azurerm_data_factory_linked_service_azure_table_storage
azurerm_data_factory_linked_service_cosmosdb
azurerm_data_factory_linked_service_data_lake_storage_gen2
azurerm_data_factory_linked_service_key_vault
azurerm_data_factory_linked_service_mysql
azurerm_data_factory_linked_service_odata
azurerm_data_factory_linked_service_postgresql
azurerm_data_factory_linked_service_sftp
azurerm_data_factory_linked_service_snowflake
azurerm_data_factory_linked_service_sql_server
azurerm_data_factory_linked_service_synapse
azurerm_data_factory_linked_service_web
azurerm_data_factory_managed_private_endpoint

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceazuredatabricks.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceazurefilestorage.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceazurefunction.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceazuresearch.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceazuresqldatabase.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceazuretablestorage.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicecosmosdb.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicedatalakestoragegen2.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicekeyvault.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicemysql.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceodata.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicepostgresql.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicesftp.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicesnowflake.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicesqlserver.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedservicesynapse.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/linkedserviceweb.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Jan 25, 2023

/test-examples="examples/datafactory/managedprivateendpoint.yaml"

sergenyalcin
sergenyalcin approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdibrov LGTM!

@kdibrov kdibrov merged commit 85a7215 into crossplane-contrib:main Jan 26, 2023
@kdibrov kdibrov deleted the issue-222 branch January 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergenyalcin sergenyalcin sergenyalcin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving datafactory(19) resources to v1beta1 version
2 participants
@kdibrov @sergenyalcin