Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurations of stream_analytics (4), synapse_workspace (1), virtual_desktop (2), virtual_hub (5), virtual_machine (2), virtual_network (1), vmware_netapp (1), vpn_server (1), web_app (2), web_pubsub (4), windows (4) groups #277

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add configurations of stream_analytics (4), synapse_workspace (1), virtual_desktop (2), virtual_hub (5), virtual_machine (2), virtual_network (1), vmware_netapp (1), vpn_server (1), web_app (2), web_pubsub (4), windows (4) groups #277

merged 1 commit into from
Feb 2, 2023

Conversation

dverveiko
Copy link
Contributor

@dverveiko dverveiko commented Feb 1, 2023 •
edited
Loading

Description of your changes

Add external name configurations without testing:

Fixes #250

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

sergenyalcin
sergenyalcin reviewed Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dverveiko left a few comments related to deprecated resources

config/externalnamenottested.go Outdated Show resolved Hide resolved
config/externalnamenottested.go Outdated Show resolved Hide resolved
@dverveiko dverveiko changed the title Add configurations of stream_analytics (4), synapse_workspace (1), video_analyzer (2), virtual_desktop (2), virtual_hub (5), virtual_machine (2), virtual_network (1), vmware_netapp (1), vpn_server (1), web_app (2), web_pubsub (4), windows (4) groups Add configurations of stream_analytics (4), synapse_workspace (1), virtual_desktop (2), virtual_hub (5), virtual_machine (2), virtual_network (1), vmware_netapp (1), vpn_server (1), web_app (2), web_pubsub (4), windows (4) groups Feb 2, 2023
@dverveiko dverveiko force-pushed the issue-250 branch 2 times, most recently from 2e4e0b9 to 37e35e8 Compare February 2, 2023 09:49
sergenyalcin
sergenyalcin approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dverveiko LGTM!

@dverveiko
Add configurations of stream_analytics (4), synapse_workspace (1), vi…
90b9539 
…deo_analyzer (2), virtual_desktop (2), virtual_hub (5), virtual_machine (2), virtual_network (1), vmware_netapp (1), vpn_server (1), web_app (2), web_pubsub (4), windows (4) groups
@dverveiko dverveiko merged commit 68b9b6e into crossplane-contrib:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergenyalcin sergenyalcin sergenyalcin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dverveiko @sergenyalcin