-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving healthcare(2), iot(1) resources to v1beta1 version #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steperchuk
force-pushed
the
issue-294
branch
from
February 10, 2023 14:14
eafae18
to
37bc400
Compare
/test-examples="examples/healthcareapis/healthcaremedtechservice.yaml" |
/test-examples="examples/healthcareapis/healthcaremedtechservicefhirdestination.yaml" |
dverveiko
reviewed
Feb 10, 2023
steperchuk
force-pushed
the
issue-294
branch
from
February 10, 2023 15:34
37bc400
to
64a7ae8
Compare
turkenf
reviewed
Feb 10, 2023
examples/healthcareapis/healthcaremedtechservicefhirdestination.yaml
Outdated
Show resolved
Hide resolved
examples/healthcareapis/healthcaremedtechservicefhirdestination.yaml
Outdated
Show resolved
Hide resolved
examples/healthcareapis/healthcaremedtechservicefhirdestination.yaml
Outdated
Show resolved
Hide resolved
steperchuk
force-pushed
the
issue-294
branch
2 times, most recently
from
February 13, 2023 09:49
816acf6
to
85456ec
Compare
turkenf
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @steperchuk
steperchuk
force-pushed
the
issue-294
branch
from
February 13, 2023 12:48
85456ec
to
37fc83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
healthcare
2iot
1Fixes #294
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Manually, as resource require account primary key to be specified after account creation.
azurerm_iot_time_series_insights_event_source_eventhub
Manually and Uptest
examples/healthcareapis/healthcaremedtechservice.yaml
examples/healthcareapis/healthcaremedtechservicefhirdestination.yaml