Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding securityinsights (2) resources #345

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

kdibrov
Copy link
Contributor

@kdibrov kdibrov commented Feb 10, 2023

Description of your changes

Fixes #343

Moving securityinsights 2 resources to v1beta1 version

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually and Uptest:
azurerm_sentinel_alert_rule_fusion
azurerm_sentinel_alert_rule_machine_learning_behavior_analytics

@kdibrov
Copy link
Contributor Author

kdibrov commented Feb 10, 2023

/test-examples="examples/securityinsights/sentinelalertrulefusion.yaml"

@kdibrov
Copy link
Contributor Author

kdibrov commented Feb 10, 2023

/test-examples="examples/securityinsights/sentinelalertrulemachinelearningbehavioranalytics.yaml"

@kdibrov kdibrov changed the title Adding securityinsights (3) resources Adding securityinsights (2) resources Feb 13, 2023
@kdibrov kdibrov force-pushed the issue-343 branch 7 times, most recently from c919b9c to b112bf9 Compare February 13, 2023 12:50
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdibrov LGTM!

@kdibrov kdibrov merged commit 11575ec into crossplane-contrib:main Feb 13, 2023
@kdibrov kdibrov deleted the issue-343 branch February 13, 2023 13:13
svscheg pushed a commit to svscheg/provider-azure that referenced this pull request Feb 13, 2023
svscheg pushed a commit to svscheg/provider-azure that referenced this pull request Feb 13, 2023
svscheg pushed a commit to svscheg/provider-azure that referenced this pull request Feb 13, 2023
svscheg pushed a commit to svscheg/provider-azure that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving securityinsights (2) resources to v1beta1
3 participants