Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MR metrics #720

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

mergenci
Copy link
Collaborator

@mergenci mergenci commented Apr 23, 2024

Description of your changes

Consume crossplane/crossplane-runtime#683 and crossplane/upjet#390.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I used the following resource configuration and applied testing steps described in crossplane-contrib/provider-upjet-aws#1281.

apiVersion: network.azure.upbound.io/v1beta1
kind: VirtualNetwork
metadata:
  name: test-pr-720-virtualnetwork
spec:
  forProvider:
    addressSpace:
      - 10.0.0.0/16
    location: "Sweden Central"
    resourceGroupName: docs

@mergenci mergenci marked this pull request as draft April 23, 2024 08:59
@mergenci
Copy link
Collaborator Author

/test-examples="examples/network/subnet.yaml"

Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
@mergenci
Copy link
Collaborator Author

/test-examples="examples/network/subnet.yaml"

@mergenci mergenci marked this pull request as ready for review April 25, 2024 13:19
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mergenci, lgtm.

@mergenci mergenci merged commit 0703c29 into crossplane-contrib:main Apr 25, 2024
12 checks passed
@mergenci mergenci deleted the mr-metrics branch April 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants