Configure BastionHost.network resource and add example manifest #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/network/v1beta1/bastionhost.yaml" |
turkenf
commented
Jul 3, 2024
config/externalname.go
Outdated
| @@ -655,6 +655,8 @@ var TerraformPluginSDKExternalNameConfigs = map[string]config.ExternalName{ | |||
| "azurerm_web_application_firewall_policy": config.TemplatedStringAsIdentifier("name", "/subscriptions/{{ .setup.configuration.subscription_id }}/resourceGroups/{{ .parameters.resource_group_name }}/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/{{ .external_name }}"), | |||
| // /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.Network/vpnServerConfigurations/serverConfiguration1/configurationPolicyGroups/configurationPolicyGroup1 | |||
| "azurerm_vpn_server_configuration_policy_group": config.TemplatedStringAsIdentifier("name", "{{ .parameters.vpn_server_configuration_id }}/configurationPolicyGroups/{{ .external_name }}"), | |||
| // /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mygroup1/providers/Microsoft.Network/bastionHosts/instance1 | |||
| "azurerm_bastion_host": config.IdentifierFromProvider, | |||
There was a problem hiding this comment.
When we set the external name configuration to the following, the update fails in the first reconcile:
"azurerm_bastion_host": config.TemplatedStringAsIdentifier("name", "/subscriptions/{{ .setup.configuration.subscription_id }}/resourceGroups/{{ .parameters.resource_group_name }}/providers/Microsoft.Network/bastionHosts/{{ .exteranl_name }}"),
Got the following error:
message: 'async update failed: refuse to update the external resource because
the following update requires replacing it: cannot change the value of the argument
"name" from "fatihtest" to "/subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/fatihtest/providers/Microsoft.Network/bastionHosts/fatihtest"'
Therefore it is set to IdentifierFromProvider
There was a problem hiding this comment.
{{ .exteranl_name }}
was there a typo?
There was a problem hiding this comment.
Good catch, @ytsarev; in case of a typo, I expect the resource not to be created. I will try and update. Thank you
There was a problem hiding this comment.
Fixing the typo eliminated the issue 🤔 I updated the description and PR.
Signed-off-by: Fatih Türken <turkenf@gmail.com>
|
/test-examples="examples/network/v1beta1/bastionhost.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR includes configuring the
BastionHost.networkresource and adding the example manifest.I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually and uptest: https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/9779701746