Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aks cluster extension feature azurerm_kubernetes_cluster_extension #818

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

drew0ps
Copy link
Contributor

@drew0ps drew0ps commented Sep 16, 2024

Description of your changes

Added the resource azurerm_kubernetes_cluster_extension which is already present in the underlying terraform release but was not made available through the provider.

Fixes #731

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Successful make e2e uptests. Multiple manual tests
  • [N/A] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Added a simple flux extension install for automated tests.
Specifying maxSurge in the AKS cluster spec precents the update loop of the cluster and unblocks tests.
Specifying North Europe as AKS region as West does not offer free tier AKS anymore.
Signed-off-by: drew0ps <ad.marton@proton.me>

Ran make generate
@drew0ps
Copy link
Contributor Author

drew0ps commented Sep 16, 2024

/test-examples="examples/containerservice/v1beta1/kubernetesclusterextension.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on adding this resource @drew0ps 🙌 LGTM.

@turkenf turkenf merged commit 55aaa68 into crossplane-contrib:main Sep 18, 2024
12 checks passed
@drew0ps drew0ps deleted the add-aks-extensions branch September 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for azurerm_kubernetes_cluster_extension resource
2 participants