Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub releases, not tags, for Earthfile deps #730

Merged
merged 1 commit into from
May 30, 2024

Conversation

negz
Copy link
Member

@negz negz commented May 30, 2024

Description of your changes

Notably CodeQL seems to have a tag cut that doesn't exist as a release.

I have:

Need help with this checklist? See the cheat sheet.

Notably CodeQL seems to have a tag cut that doesn't exist as a release.

Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz negz requested a review from a team as a code owner May 30, 2024 20:56
@negz negz requested a review from phisco May 30, 2024 20:56
@@ -40,7 +40,7 @@
"matchStrings": [
"EARTHLY_VERSION: '(?<currentValue>.*?)'\\n"
],
"datasourceTemplate": "github-tags",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intended for other managers besides just codeql?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured since we always download release artifact URLs it's better to use the existence of a release as the datasource everywhere.

@negz negz merged commit a4e82d5 into crossplane:master May 30, 2024
9 of 10 checks passed
@negz negz deleted the third-rock-from-the-sun branch May 30, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants