-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init
- add option to select branch/tag
#5391
Conversation
Signed-off-by: lsviben <sviben.lovro@gmail.com>
init
- add option to select branch/tag
I know its late, but I wonder if its worth including this in v1.15 as it would help folks working on template post-init hooks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine having this back-ported, @jbw976 I'll leave to you the last call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this functionality seems to work when I just tested, and it would have been nice to have yesterday while testing the new content you were adding to https://github.com/lsviben/configuration-template/tree/skelly that wasn't in the main branch yet 😂
This is very low risk, so I'm not against backporting it too.
Successfully created backport PR for |
My pain yesterday made me do this, actually did it during working on that. You could say its first-hand dev experience improvements 😁 |
Description of your changes
Noticed during the creation of the configuration-template that its annoying that the
init
command just clones themain
branch without any options to change. It makes it difficult to test theinit
commands NOTES.txt andinit.sh
script during development.With this option, you can choose a tag or branch name to clone from. It should make developing templates easier.
Example:
I have:
make reviewable
to ensure this PR is ready for review.[] Added or updated unit tests.[] Added or updated e2e tests.[] Addedbackport release-x.y
labels to auto-backport this PR.Need help with this checklist? See the cheat sheet.