fix(helm): Explicitly set divisor in rbac-manager resources #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sources Signed-off-by: Maxence Boutet <52334444+mboutet@users.noreply.github.com>
bobh66
approved these changes
Mar 28, 2024
jbw976
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Looks like this is the 3rd PR in a series of fixes like this, thanks for being lucky number 3 @mboutet 😇
previous 2 PRs:
- fix(chart): explicitly set resourceFieldRef.divisor to avoid flapping #4538
- [bug] helm chart: explicitly set divisor in container resources #5198
Do you feel like this covers the full extent of where this divisor field should be set? or are there any potentially lingering locations to still consider? 🤔
|
@jbw976, seems like it was the only remaining place those were missing. |
|
Could this be backported to release-1.15 branch? For future release of 1.15 helm chart to have the fix? |
|
/backport |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a divisor section in the
rbac-managerDeployment of the Helm Chart, solving a continuous sync when Crossplane is deployed with ArgoCD.This is an extension of #5198.
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Addedbackport release-x.ylabels to auto-backport this PR.