Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToAdler32 to CRDs #5560

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add ToAdler32 to CRDs #5560

merged 1 commit into from
Apr 9, 2024

Conversation

eskabetxe
Copy link
Contributor

@eskabetxe eskabetxe commented Apr 9, 2024

Description of your changes

Add ToAddler32 to CRDs

Fixes #5559

I have:

Need help with this checklist? See the cheat sheet.

@phisco
Copy link
Contributor

phisco commented Apr 9, 2024

Hi, thanks @eskabetxe! Looks like the autogenerated code is still behind, could you run: make reviewable? Run git submodule update --init --recursive if you don't have the build submodule locally initialised yet.

Signed-off-by: Joao Boto <boto@boto.pro>
@eskabetxe
Copy link
Contributor Author

@phisco done.. I miss a file sorry.

@phisco phisco merged commit 01a60bd into crossplane:master Apr 9, 2024
14 of 17 checks passed
Copy link

github-actions bot commented Apr 9, 2024

Backport failed for release-1.14, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.14
git worktree add -d .worktree/backport-5560-to-release-1.14 origin/release-1.14
cd .worktree/backport-5560-to-release-1.14
git switch --create backport-5560-to-release-1.14
git cherry-pick -x 6cbdd0a37961472d90233f6dbe148f63cbffc45a

Copy link

github-actions bot commented Apr 9, 2024

Successfully created backport PR for release-1.15:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use ToAdler32 as string convertion
2 participants