fix: crossplane xpkg init doesn't close file #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com> Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
cychiang
force-pushed
the
fix-xpkg-doesnt-close-file
branch
from
e75cc03
to
d88600f
Compare
…ore. Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
cychiang
force-pushed
the
fix-xpkg-doesnt-close-file
branch
from
71021f6
to
9644d74
Compare
bobh66
reviewed
May 21, 2024
Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
negz
approved these changes
May 22, 2024
|
Thank you! |
phisco
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Based on the previous #5632 with the fix for linting.
I believe it's safe to not handle the error. The whole function is doing read only, and not doing any write operation.
Fixes #5717
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.