Improvements to DesiredComposedResources and ObservedComposedResources
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These just served to obfuscate what the types actually were - a map of resource name to observed/desired composed resource structs. Signed-off-by: Nic Cope <nicc@rk0n.org>
This makes it possible to mutate struct values while iterating over the
map of composed resources. I found myself naturally wanting to do this
while writing a Function. e.g.:
desired, _ = request.GetDesiredComposedResources(req)
for _, dr := range desired {
dr.Ready = resource.ReadyTrue
}
_ = response.SetDesiredComposedResources(desired)
I haven't made the same change for observed resources, since they're
supposed to be read-only to a Function.
Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This makes it possible to mutate struct values while iterating over the map of composed resources. I found myself naturally wanting to do this while writing a Function. e.g.:
I haven't made the same change for observed resources, since they're supposed to be read-only to a Function.
This PR also removes the
DesiredComposedResourcesandObservedComposedResourcestypes. I found they were just obfuscating what the types actually were when I tried to use them.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested