This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Add an optional workload type field in the component workload spec. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
The idea is really good and interesting, This could also fix #182 I think.
| @@ -139,5 +139,5 @@ func (h *ValidatingHandler) InjectDecoder(d *admission.Decoder) error { | |||
| // Register will regsiter application configuration validation to webhook | |||
| func Register(mgr manager.Manager) { | |||
| server := mgr.GetWebhookServer() | |||
| server.Register("/validating-applicationconfigurations", &webhook.Admission{Handler: &ValidatingHandler{}}) | |||
| server.Register("/validating-core-oam-dev-v1alpha2-applicationconfigurations", &webhook.Admission{Handler: &ValidatingHandler{}}) | |||
There was a problem hiding this comment.
I would vote for /v1alpha2/validating-applicationconfigurations if we want to add version in path.
There was a problem hiding this comment.
I think we need to come up with a uniformed way for webhooks register in vela. Let's add a PR after this
| } | ||
| if content[TypeField] != nil { | ||
| allErrs = append(allErrs, field.Invalid(fldPath.Child("workload"), obj.Spec.Workload, | ||
| fmt.Sprintf("the workload `%+v` is not a CR", obj.Spec.Workload))) |
There was a problem hiding this comment.
Suggested change
| fmt.Sprintf("the workload `%+v` is not a CR", obj.Spec.Workload))) | |
| fmt.Sprintf("the workload `%+v` is not a K8s CR", obj.Spec.Workload))) |
|
|
||
| // ValidateUpdate validates the Component on update | ||
| func ValidateUpdate(r *v1alpha2.Component, _ *v1alpha2.Component) field.ErrorList { | ||
| validatelog.Info("validate update", "name", r.Name) |
There was a problem hiding this comment.
Should validate the same thing like ValidateCreate
|
Is this PR ready for review? |
ryanzhang-oss
force-pushed
the
add-workload-type
branch
2 times, most recently
from
ad1378a
to
3c01d27
Compare
ryanzhang-oss
changed the title
The test took me some time to add |
ryanzhang-oss
force-pushed
the
add-workload-type
branch
3 times, most recently
from
8ffd901
to
36d9a48
Compare
wonderflow
reviewed
Sep 10, 2020
wonderflow
reviewed
Sep 10, 2020
wonderflow
reviewed
Sep 10, 2020
wonderflow
reviewed
Sep 10, 2020
Comment on lines
+107
to
+114
| var _ inject.Client = &ValidatingHandler{} | ||
|
|
||
| // InjectClient injects the client into the ComponentValidatingHandler | ||
| func (h *ValidatingHandler) InjectClient(c client.Client) error { | ||
| h.Client = c | ||
| return nil | ||
| } | ||
| */ |
There was a problem hiding this comment.
not for the validating handler
ryanzhang-oss
force-pushed
the
add-workload-type
branch
2 times, most recently
from
9a35637
to
4224c23
Compare
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
ryanzhang-oss
force-pushed
the
add-workload-type
branch
from
4224c23
to
41eb0c6
Compare
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use component webhooks to mutate and validate the component workload spec when workload "type" is used instead of a full CR.
Unit tests added
manually E2E tested