Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

status.historyWorkloads should not be required in AC #250

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

wonderflow
Copy link
Member

This PR fixes below case:

When error return, we don't set status of AC, then it complains:

2020-10-15T16:20:26.562+0800	ERROR	controller-runtime.controller	Reconciler error	{"controller": "oam/applicationconfiguration.core.oam.dev", "request": "default/myapp", "error": "cannot update application configuration status: ApplicationConfiguration.core.oam.dev \"myapp\" is invalid: status.historyWorkloads: Invalid value: \"null\": status.historyWorkloads in body must be of type array: \"null\"", "errorVerbose": "ApplicationConfiguration.core.oam.dev \"myapp\" is invalid: status.historyWorkloads: Invalid value: \"null\": status.historyWorkloads in body must be of type array: \"null\"\ncannot update application configuration status\ngithub.com/crossplane/oam-kubernetes-runtime/pkg/controller/v1alpha2/applicationconfiguration.(*OAMApplicationReconciler).Reconcile.func1\n\t/Users/sunjianbo/gopath/pkg/mod/github.com/crossplane/oam-kubernetes-runtime@v0.3.0-rc1/pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration.go:244\ngithub.com/crossplane/oam-kubernetes-runtime/pkg/controller/v1alpha2/applicationconfiguration.(*OAMApplicationReconciler).Reconcile\n\t/Users/sunjianbo/gopath/pkg/mod/github.com/crossplane/oam-kubernetes-runtime@v0.3.0-rc1/pkg/controller/v1alpha2/applicationconfiguration/applicationconfiguration.go:275\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/Users/sunjianbo/gopath/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/internal/controller/controller.go:256\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/Users/sunjianbo/gopath/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/internal/controller/controller.go:232\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\t/Users/sunjianbo/gopath/pkg/mod/sigs.k8s.io/controller-runtime@v0.6.0/pkg/internal/controller/controller.go:211\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/Users/sunjianbo/gopath/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/Users/sunjianbo/gopath/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/Users/sunjianbo/gopath/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\t/Users/sunjianbo/gopath/pkg/mod/k8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:90\nruntime.goexit\n\t/usr/local/Cellar/go/1.14.2_1/libexec/src/runtime/asm_amd64.s:1373"}

Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
@ryanzhang-oss ryanzhang-oss merged commit 255734a into crossplane:master Oct 15, 2020
@wonderflow wonderflow deleted the status branch October 15, 2020 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants