This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
don't block app from running if no definition found #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
force-pushed
the
fixig
branch
4 times, most recently
from
35341f2
to
ce62e66
Compare
| @@ -453,7 +457,10 @@ func (w Workload) Status() v1alpha2.WorkloadStatus { | |||
| Traits: make([]v1alpha2.WorkloadTrait, len(w.Traits)), | |||
| Scopes: make([]v1alpha2.WorkloadScope, len(w.Scopes)), | |||
| } | |||
| for i := range w.Traits { | |||
| for i, tr := range w.Traits { | |||
| if tr.Definition.Name == util.Dummy && tr.Definition.Spec.Reference.Name == util.Dummy { | |||
There was a problem hiding this comment.
It seems that this only applies to traits. What about workloads?
There was a problem hiding this comment.
we don't check workloadDef when apply worklaod.
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #82