This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
New acronyms #183
Merged
New acronyms #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <me@muvaf.com>
muvaf
commented
Dec 21, 2021
| @@ -87,17 +86,17 @@ func DefaultResource(name string, terraformSchema *schema.Resource, opts ...Reso | |||
| // - aws_rds_cluster => Cluster | |||
| // - aws_rds_cluster_parameter_group => ClusterParameterGroup | |||
| // - kafka_topic => Topic | |||
| kind := strcase.ToCamel(strings.Join(words[2:], "_")) | |||
| kind := tjname.NewFromSnake(strings.Join(words[2:], "_")).Camel | |||
There was a problem hiding this comment.
Otherwise, strcase.ToCamel treates ec2 as two words Ec and 2, which causes it not to be found in the acronyms list.
There was a problem hiding this comment.
I needed this in provider-jet-gcp as well for hl7 to HL7 👍
2 tasks
…n be handled properly because first converting to camel makes it see ec and 2 as different words Signed-off-by: Muvaffak Onus <me@muvaf.com>
turkenh
approved these changes
Dec 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds new acronyms that I needed in Jet AWS to the list. Some of them are AWS-specific, like EC2, but I think that's probably harmless since there is no context that they can be real words.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
With Jet AWS.