Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for converting Crossplane Configurations #209

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented May 24, 2023

Description of your changes

This PR adds support for generating plans of multiple migration scenarios. It adds support for converting Crossplane Configuration v1 and v1alpha1 metadata to the migration framework. It also adds the migration.Executor interface.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

TODO:

  • Test the generated JSON merge document for the converted configuration

@ulucinar ulucinar marked this pull request as draft May 24, 2023 07:25
- Add the migration.Executor interface

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
- Do not generate empty steps in the migration plan

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar marked this pull request as ready for review May 25, 2023 06:40
- Generate Configuration migration steps named:
  - new-ssop: Installs new SSOPs that will replace a monolithic provider package
  - edit-monolithic-provider: Sets spec.SkipDependencyResolution:true for a monolithic provider
  - delete-monolithic-provider: Deletes a monolithic provider package
  - activate-ssop: Activates the new SSOPs installed

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar force-pushed the configuration-migration branch 4 times, most recently from a881031 to ca907c3 Compare May 26, 2023 19:19
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Copy link
Member

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@sergenyalcin sergenyalcin merged commit 5f2dad2 into crossplane:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants