Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc-generator): fix generation examples for provider-vault #238

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

haarchri
Copy link
Contributor

@haarchri haarchri commented Jul 26, 2023

Description of your changes

the page_title is different for provider-vault then to other providers
page_title: "Vault: vault_ad_secret_backend_library resource"
for that reason i added a small code path to make the example generation working

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

see Draft PR:
upbound/provider-vault#4

replace github.com/upbound/upjet => github.com/haarchri/upjet v0.9.0-rc.0.0.20230726-fb8ce3c61376be3aa89d8516adc69ced18544e10

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
Copy link
Contributor Author

tested with upbound/provider-aws

add to go.mod replace github.com/upbound/upjet => github.com/haarchri/upjet v0.9.0-rc.0.0.20230726-fb8ce3c61376be3aa89d8516adc69ced18544e10

rm -rf examples-generated folder 
make generate
[...]
ls -ali | grep "examples-generated"
5406218 drwxr-x---@ 158 haarchri  staff   5056 Jul 31 13:53 examples-generated

git diff examples-generated is empty without changes

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri, lgtm.

@haarchri haarchri merged commit 39dcb37 into crossplane:main Aug 1, 2023
4 checks passed
@haarchri haarchri mentioned this pull request Aug 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants