Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the inUse count to SharedProviderScheduler log statements #261

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

toastwaffle
Copy link
Contributor

Description of your changes

This exposes the inUse count in debug log statements.

We upgraded upbound-provider-gcp to v0.35.0 recently, and saw a number of occasions where it got completely stuck because the provider runner had expired but wasn't being recreated. I suspect this is because the inUse count hadn't been decremented at some point, but we weren't able to tell; this change is the first step towards debugging that.

This is related to crossplane-contrib/provider-upjet-gcp#348

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Ran unit tests

@toastwaffle
Copy link
Contributor Author

The test which failed appears to be flaky - it failed for me when I ran make reviewable test, and then passed when I ran it again. Looks like the ordering of the slice it's checking isn't consistent.

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @toastwaffle, lgtm.

@ulucinar ulucinar merged commit ce56bba into crossplane:main Aug 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants