Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular management policy - promote to BETA #288

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Oct 11, 2023

Description of your changes

Fixes some linter issues in the original PR and bumps to latest Crossplane Runtime today.

Bumps crossplane-runtime to a version in which GMP is beta. Just bumping crossplane-runtime gave me this issue so I needed to bump a few more things.

P.S: I couldn't push to that PR due to lack of permissions.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with provider-aws, creating a DynamoDB Table with using initProvider and managementPolicies.

turkenh and others added 3 commits October 11, 2023 12:48
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: lsviben <sviben.lovro@gmail.com>
Signed-off-by: lsviben <sviben.lovro@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh, lgtm.

pkg/migration/fake/mocks/mock.go Show resolved Hide resolved
@ulucinar
Copy link
Collaborator

ulucinar commented Oct 11, 2023

The TestNewKubernetesSource is sporadically failing. Retrigerred them...

@jeanduplessis jeanduplessis reopened this Oct 11, 2023
@ulucinar ulucinar merged commit c4a76d2 into crossplane:main Oct 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants