Set the ID string to empty string on Terraform state for calculating the diffs #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the diffs when the resource does not yet exist. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
It turns out that using a
nilterraform.InstanceStatefor new resources while calculating theterraform.InstanceDiffbreaks the verify.SetTagsDiff implementation. This PR resets the Terraform ID string to the empty string interraform.InstanceStatepassed down to thenoForkExternal.getResourceDataDiffso that the issue first observed in theCustomizeDiffimplementation ofReplicationGroup.elasticacheis resolved.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested via uptest in crossplane-contrib/provider-upjet-aws#1119: https://github.com/upbound/provider-aws/actions/runs/7729719052/job/21073558871