Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manipulator function for every schema field #89

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Manipulator function for every schema field #89

merged 3 commits into from
Sep 2, 2022

Conversation

sergenyalcin
Copy link
Member

@sergenyalcin sergenyalcin commented Sep 1, 2022

Description of your changes

Related https://github.com/upbound/official-providers/issues/553

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make generate in provider-gcp

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @sergenyalcin !

pkg/config/common.go Outdated Show resolved Hide resolved
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin merged commit 4a134d3 into crossplane:main Sep 2, 2022
@sergenyalcin sergenyalcin deleted the schema-manipulator branch September 2, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants