GCW-3508-Default message UI #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 17, 2021 18:33
abulsayyad123
requested review from
bharat619,
patrixr,
shreyas098 and
swatijadhav
shreyas098
reviewed
Feb 26, 2021
| {{/if}} | ||
| <div class="row edit-message"> | ||
| <span clas="small-3 columns" style="flex: 1;text-align: center;"> | ||
| Label* |
bharat619
reviewed
Feb 26, 2021
Comment on lines
12
to
18
| let message; | ||
| if (editMessage.messageId) { | ||
| message = store.peekRecord("canned_response", editMessage.messageId); | ||
| } else { | ||
| message = store.createRecord("canned-response"); | ||
| } | ||
| this.set("message", message); |
There was a problem hiding this comment.
Suggested change
| let message; | |
| if (editMessage.messageId) { | |
| message = store.peekRecord("canned_response", editMessage.messageId); | |
| } else { | |
| message = store.createRecord("canned-response"); | |
| } | |
| this.set("message", message); | |
| const message = store.peekRecord("canned_response", editMessage.messageId) || store.createRecord("canned-response"); | |
| this.set("message", message); |
bharat619
reviewed
Feb 26, 2021
| positionalParams: ["value"] | ||
| }); | ||
|
|
||
| export default AliasComponent; |
bharat619
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link:
https://jira.crossroads.org.hk/browse/GCW-3508
What does this PR do?
This PR adds UI for adding default message.