GCW-2785 Add pop up for navigating from empty offer screen #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharat619
requested review from
patrixr,
abulsayyad123,
shreyas098,
steveyken and
swatijadhav
patrixr
reviewed
Mar 4, 2021
| @@ -97,6 +97,17 @@ export default Ember.Controller.extend(AsyncTasksMixin, { | |||
| } | |||
| }), | |||
|
|
|||
| deleteOffer(offer, path = this.get("backLinkPath")) { | |||
| this.set("cancelByMe", true); | |||
There was a problem hiding this comment.
Unrelated to this Pr: this "cancelByMe" feels wrong to me
patrixr
approved these changes
Mar 4, 2021
abulsayyad123
approved these changes
Mar 4, 2021
swatijadhav
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link:
https://jira.crossroads.org.hk/browse/GCW-2785
What does this PR do?
Adds popup for offer deletion on clicking back button from empty offer