Synchronize mouse button events coordinates with the cursor

[zrzka]

I find it a bit weird that the cursor does use 0, 0 for the first column/row, but the mouse events do use 1, 1 for the first column/row. I'd assume that everything starts from 0, 0.

Not much investigation done on my side, I just noticed this when working on the documentation/examples.

[TimonPost]

I am going to validate this, if it is different, yes then it should be synced.

[zrzka]

@TimonPost did you have a chance to validate this issue on Windows as well? Before touching it, I'd like to be sure that this isn't just some macOS/UNIX quirk or even just my computer only.

[zrzka]

All three types with coordinates are producing numbers starting at 1.

My test code:

use crossterm_input::{InputEvent, KeyEvent, MouseEvent, RawScreen, Result, TerminalInput};

fn main() -> Result<()> {
    let input = TerminalInput::new();
    let _raw = RawScreen::into_raw_mode()?;

    let mut reader = input.read_sync();
    input.enable_mouse_mode()?;

    loop {
        if let Some(event) = reader.next() {
            match event {
                InputEvent::Keyboard(KeyEvent::Esc) => break,
                InputEvent::Keyboard(KeyEvent::Enter) => println!("Enter"),
                InputEvent::Mouse(mouse) => {
                    match mouse {
                        MouseEvent::Press(_, x, y) => println!("Press: {}x{}", x, y),
                        MouseEvent::Hold(x, y) => println!("Move: {}x{}", x, y),
                        MouseEvent::Release(x, y) => println!("Release: {}x{}", x, y),
                        _ => {}
                    };
                }
                _ => {}
            };
        }
    }

    input.disable_mouse_mode()?;
    Ok(())
}

[TimonPost]

In the windows terminal, they start with 1,1 as well

[zrzka]

Thanks, will PR it later today ...