Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for focus change event (#784) #864

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

illiteratewriter
Copy link
Contributor

No description provided.

@illiteratewriter
Copy link
Contributor Author

I was also thinking of adding the following lines to the example in the docs:

execute!(
        stdout,
        EnableBracketedPaste,
        EnableFocusChange,
        EnableMouseCapture,
    )?;

so that there is better clarity in the example. Let me know if this sounds like a good addition.

Copy link
Collaborator

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple doc change which is correct and is reasonable to merge, though it could be improved by the addition suggested (execute commands).

src/event.rs Outdated Show resolved Hide resolved
@joshka
Copy link
Collaborator

joshka commented May 6, 2024

I was also thinking of adding the following lines to the example in the docs:

Yes - this would be a good idea. Don't forget the corresponding disable though.

Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@TimonPost TimonPost merged commit 61ff5ae into crossterm-rs:master Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants