Create link to applications folder in DMG without background image #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crotwell
reviewed
Jul 12, 2018
There was a problem hiding this comment.
Look fine but I think mounting and unmounting the dmg is a somewhat expensive operation (~ 200 msec). Perhaps would be better to do the mount once, then do createLinkToApplicationsFolder and/or doBackgroundImageAppleScript and then unmount. Basically refactor the mounting out of these two functions?
Would you be willing to try this?
|
On second thought, maybe not that big of a deal, will merge this. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.