fix: CrowdinValidationError and handle single error (#341)

crowdin · Nov 21, 2023 · 27f342f · 27f342f
1 parent da3ad74
commit 27f342f
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 10 deletions.
diff --git a/src/core/index.ts b/src/core/index.ts
@@ -133,24 +133,32 @@ export class CrowdinError extends Error {
  */
 export class CrowdinValidationError extends CrowdinError {
     public validationCodes: { key: string; codes: string[] }[];
-    constructor(messsage: string, validationCodes: { key: string; codes: string[] }[]) {
-        super(messsage, 400);
+    constructor(message: string, validationCodes: { key: string; codes: string[] }[]) {
+        super(message, 400);
         this.validationCodes = validationCodes;
     }
 }
 
+function isAxiosError(error: any): error is AxiosError {
+    return error instanceof AxiosError || !!error.response?.data;
+}
+
 /**
  * @internal
  */
 export function handleHttpClientError(error: HttpClientError): never {
-    const crowdinResponseErrors =
-        error instanceof AxiosError
-            ? error.response?.data?.errors
-            : error instanceof FetchClientJsonPayloadError
-            ? error.jsonPayload && typeof error.jsonPayload === 'object' && 'errors' in error.jsonPayload
-                ? error.jsonPayload.errors
-                : null
-            : null;
+    let crowdinResponseErrors: any = null;
+
+    if (isAxiosError(error)) {
+        crowdinResponseErrors = (error.response?.data as any)?.errors || (error.response?.data as any)?.error;
+    } else if (error instanceof FetchClientJsonPayloadError) {
+        crowdinResponseErrors =
+            error.jsonPayload &&
+            typeof error.jsonPayload === 'object' &&
+            ('errors' in error.jsonPayload || 'error' in error.jsonPayload)
+                ? error.jsonPayload.errors || error.jsonPayload.error
+                : null;
+    }
 
     if (Array.isArray(crowdinResponseErrors)) {
         const validationCodes: { key: string; codes: string[] }[] = [];
@@ -172,7 +180,10 @@ export function handleHttpClientError(error: HttpClientError): never {
         });
         const message = validationMessages.length === 0 ? 'Validation error' : validationMessages.join(', ');
         throw new CrowdinValidationError(message, validationCodes);
+    } else if (crowdinResponseErrors?.message && crowdinResponseErrors?.code) {
+        throw new CrowdinError(crowdinResponseErrors.message, crowdinResponseErrors.code);
     }
+
     if (error instanceof Error) {
         const code =
             error instanceof AxiosError && error.response?.status

diff --git a/tests/core/error-handling.test.ts b/tests/core/error-handling.test.ts
@@ -18,6 +18,13 @@ const genericCrowdinErrorPayload = {
     ],
 };
 
+const genericCrowdinSingleErrorPayload = {
+    error: {
+        message: 'test_errors_error_msg',
+        code: 403,
+    },
+};
+
 const stringBatchOperationsErrorPayload = {
     errors: [
         {
@@ -88,6 +95,11 @@ describe('core http error handling', () => {
         }
     });
 
+    it('should extract Crowdin API single message with axios client', async () => {
+        const error = createAxiosError(genericCrowdinSingleErrorPayload);
+        expect(() => handleHttpClientError(error)).toThrowError(genericCrowdinSingleErrorPayload.error.message);
+    });
+
     it('should print full error message for stringBatchOperations axios errors', async () => {
         const error = createAxiosError(stringBatchOperationsErrorPayload);
         expect(() => handleHttpClientError(error)).toThrowError(