Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling improvements #171

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Error handling improvements #171

merged 2 commits into from
Apr 23, 2022

Conversation

yevheniyJ
Copy link
Collaborator

@yevheniyJ yevheniyJ commented Apr 23, 2022

Improved error handling to throw Error instances

@yevheniyJ yevheniyJ linked an issue Apr 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #171 (e609105) into master (07a4d31) will decrease coverage by 1.07%.
The diff coverage is 31.43%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   82.46%   81.40%   -1.06%     
==========================================
  Files          29       29              
  Lines        1123     1145      +22     
  Branches       94       97       +3     
==========================================
+ Hits          926      932       +6     
- Misses        136      152      +16     
  Partials       61       61              
Impacted Files Coverage Δ
src/core/internal/axios/axiosProvider.ts 84.00% <0.00%> (+16.26%) ⬆️
src/core/index.ts 41.61% <32.36%> (-5.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a4d31...e609105. Read the comment docs.

@yevheniyJ yevheniyJ marked this pull request as ready for review April 23, 2022 09:44
@yevheniyJ yevheniyJ merged commit 9356539 into master Apr 23, 2022
@yevheniyJ yevheniyJ deleted the error-handling branch April 23, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Reject and throw only error instances
1 participant