Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'streamIsEmpty' error should fail the program execution #383

Closed
DmPanov opened this issue Jul 21, 2021 · 1 comment · Fixed by #389 or #397
Closed

'streamIsEmpty' error should fail the program execution #383

DmPanov opened this issue Jul 21, 2021 · 1 comment · Fixed by #389 or #397
Labels
bug good first issue

Comments

@DmPanov
Copy link

DmPanov commented Jul 21, 2021

Description
crowdin push sources exits with 0 despite the streamIsEmpty error shown in log.

❌ Wrong parameters:
  <key: fileStream, code: streamIsEmpty, message: Stream size is null. Not empty content expected>

To Reproduce
Execute crowdin push sources with some of the source files being empty.

Expected behavior
crowdin push sources should exit with 1 to clearly indicate an error.

Environment:
Ubuntu 18.04.5 LTS
@DmPanov DmPanov added the bug label Jul 21, 2021
@andrii-bodnar andrii-bodnar linked a pull request Aug 19, 2021 that will close this issue
Improvements: little fixes and new 'custom_segmentation' field #389
Merged
@andrii-bodnar andrii-bodnar linked a pull request Sep 7, 2021 that will close this issue
Version 3.7.0 #397
Merged
@DmPanov
Copy link
Author

DmPanov commented Nov 25, 2021

I'm still getting this error with 3.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
2 participants
@andrii-bodnar @DmPanov