Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: little fixes and new 'custom_segmentation' field #389

Merged
merged 5 commits into from
Sep 17, 2021

Conversation

frombetelgeuse
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #389 (d324b5f) into cli3 (5d54ac1) will decrease coverage by 0.11%.
The diff coverage is 61.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##               cli3     #389      +/-   ##
============================================
- Coverage     57.01%   56.90%   -0.10%     
+ Complexity      932      931       -1     
============================================
  Files           153      153              
  Lines          4542     4570      +28     
  Branches        685      683       -2     
============================================
+ Hits           2589     2600      +11     
- Misses         1633     1650      +17     
  Partials        320      320              
Impacted Files Coverage Δ
...java/com/crowdin/cli/client/CrowdinClientCore.java 62.50% <0.00%> (-8.75%) ⬇️
...m/crowdin/cli/commands/actions/GenerateAction.java 68.32% <0.00%> (ø)
.../com/crowdin/cli/properties/PropertiesBuilder.java 52.11% <ø> (ø)
...ain/java/com/crowdin/cli/utils/http/OAuthUtil.java 0.00% <0.00%> (ø)
...wdin/cli/commands/actions/UploadSourcesAction.java 48.39% <27.78%> (-1.40%) ⬇️
...main/java/com/crowdin/cli/properties/FileBean.java 58.72% <62.50%> (+1.17%) ⬆️
...a/com/crowdin/cli/client/CrowdinProjectClient.java 72.73% <85.72%> (+0.07%) ⬆️
...crowdin/cli/commands/actions/StringListAction.java 77.09% <88.89%> (+0.90%) ⬆️
...java/com/crowdin/cli/client/ResponseException.java 100.00% <100.00%> (ø)
...a/com/crowdin/cli/commands/actions/CliActions.java 80.77% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d54ac1...d324b5f. Read the comment docs.

- Fix exception handling at uploading file to storage in 'upload source' action
- Fix showing New version banner with '--plain' param
- Fix message in authorizing via browser
@andrii-bodnar andrii-bodnar merged commit 79f62eb into cli3 Sep 17, 2021
@andrii-bodnar andrii-bodnar deleted the improvements branch September 17, 2021 07:34
Copy link

@t10-13rocket t10-13rocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants