Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #374

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Improvements #374

merged 4 commits into from
Jul 20, 2021

Conversation

frombetelgeuse
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #374 (637d206) into cli3 (d9ff46a) will increase coverage by 0.15%.
The diff coverage is 66.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##               cli3     #374      +/-   ##
============================================
+ Coverage     58.15%   58.29%   +0.15%     
- Complexity      878      920      +42     
============================================
  Files           143      144       +1     
  Lines          4186     4368     +182     
  Branches        624      653      +29     
============================================
+ Hits           2434     2546     +112     
- Misses         1457     1513      +56     
- Partials        295      309      +14     
Impacted Files Coverage Δ
...ava/com/crowdin/cli/client/CrowdinProjectFull.java 57.15% <0.00%> (-35.16%) ⬇️
...com/crowdin/cli/commands/actions/StatusAction.java 15.39% <13.34%> (-2.56%) ⬇️
...a/com/crowdin/cli/client/CrowdinProjectClient.java 75.38% <20.00%> (-7.27%) ⬇️
...wdin/cli/commands/actions/UploadSourcesAction.java 50.22% <33.34%> (-2.31%) ⬇️
...ubactions/DeleteObsoleteProjectFilesSubAction.java 80.56% <80.56%> (ø)
src/main/java/com/crowdin/cli/utils/Utils.java 68.19% <90.00%> (+5.33%) ⬆️
.../cli/commands/functionality/ProjectFilesUtils.java 82.42% <94.88%> (+9.35%) ⬆️
...a/com/crowdin/cli/commands/actions/CliActions.java 87.50% <100.00%> (ø)
...commands/picocli/StatusProofreadingSubcommand.java 100.00% <100.00%> (ø)
...crowdin/cli/commands/picocli/StatusSubcommand.java 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ff46a...637d206. Read the comment docs.

@frombetelgeuse frombetelgeuse changed the title Add 'delete obsolete' sub-action to 'upload sources' Improvements Jul 1, 2021
@andrii-bodnar andrii-bodnar merged commit 2e1da0b into cli3 Jul 20, 2021
@andrii-bodnar andrii-bodnar deleted the add-delete-obsolete-option branch July 20, 2021 11:33
@andrii-bodnar andrii-bodnar linked an issue Jul 20, 2021 that may be closed by this pull request
@andrii-bodnar andrii-bodnar mentioned this pull request Jul 29, 2021
@coyoteecd
Copy link

@andrii-bodnar this PR should've included an update to the documentation, this option is not mentioned anywhere except source and small note in changelog

@andrii-bodnar
Copy link
Member

Hi @coyoteecd! Thanks for pointing it out.

Samples in the readme are more about simple usage of CLI. We will update articles in our Knowledge Base (Console Client, Configuration File) as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation Status by Branch
3 participants