-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more tests for better coverage #509
Conversation
…r tagerts test, deleting extra lines,
# Conflicts: # src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Codecov Report
@@ Coverage Diff @@
## cli3 #509 +/- ##
=========================================
Coverage 59.47% 59.47%
Complexity 1036 1036
=========================================
Files 153 153
Lines 4771 4771
Branches 737 737
=========================================
Hits 2837 2837
Misses 1538 1538
Partials 396 396 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @calfaand, thanks a lot for your contribution! 🚀 It's strange but it seems like the new tests are not affecting the coverage (according to the codecov comment) Could you please take a look? |
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
Yes it seems strange to me because I verified it in Intelijj idea and it shows different coverage, but I take look at it later afternoon |
@calfaand thank you! I'm going to merge this PR and then will see if the coverage will be increased. |
@calfaand the coverage wasn't changed after the merge. But I found another interesting thing: The but the It could be the reason for not accounting coverage. Could you please move the test class to the right namespace? |
No description provided.