Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: glossary & tm updates #737

Merged
merged 9 commits into from
Mar 18, 2024
Merged

feat: glossary & tm updates #737

merged 9 commits into from
Mar 18, 2024

Conversation

yevheniyJ
Copy link
Collaborator

@yevheniyJ yevheniyJ commented Mar 17, 2024

  • removed name prop (from upload and download commands)
  • moved id to arguments (only for download commands)
  • updated list cmd output

Before:

  • crowdin tm download --id <id> or crowdin tm download --name <name>
  • crowdin glossary download --id <id> or crowdin glossary download --name <name>

After:

(Use list command to get id)

  • crowdin tm download <id>
  • crowdin glossary download <id>

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.35%. Comparing base (ea9e64d) to head (f101dc9).

Files Patch % Lines
...cli/commands/picocli/GlossaryUploadSubcommand.java 0.00% 1 Missing and 1 partial ⚠️
...din/cli/commands/actions/GlossaryUploadAction.java 80.00% 0 Missing and 1 partial ⚠️
...owdin/cli/commands/picocli/TmUploadSubcommand.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             next-v4     #737      +/-   ##
=============================================
- Coverage      63.79%   63.35%   -0.44%     
+ Complexity      1506     1463      -43     
=============================================
  Files            220      220              
  Lines           6302     6207      -95     
  Branches         945      922      -23     
=============================================
- Hits            4020     3932      -88     
- Misses          1778     1780       +2     
+ Partials         504      495       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yevheniyJ yevheniyJ marked this pull request as ready for review March 17, 2024 16:07
@andrii-bodnar andrii-bodnar added this to the v4 milestone Mar 18, 2024
@andrii-bodnar andrii-bodnar merged commit b83624b into next-v4 Mar 18, 2024
8 checks passed
@andrii-bodnar andrii-bodnar deleted the tm-glossary-updates branch March 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants