Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved exit codes #785

Merged
merged 4 commits into from
May 13, 2024
Merged

feat: improved exit codes #785

merged 4 commits into from
May 13, 2024

Conversation

yevheniyJ
Copy link
Collaborator

@yevheniyJ yevheniyJ commented May 11, 2024

List of exit codes:

  • 0 Success
  • 1 Generic Error
  • 2 Validation Error
  • 101 Authorization Error
  • 102 Not Found Error
  • 103 Forbidden Error
  • 129 Rate Limit Error

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 32.65306% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 65.27%. Comparing base (843cee9) to head (e8fe662).

Files Patch % Lines
...wdin/cli/commands/actions/UploadSourcesAction.java 0.00% 18 Missing ⚠️
.../cli/commands/picocli/ExitCodeExceptionMapper.java 51.36% 16 Missing and 2 partials ⚠️
.../commands/actions/FileUploadTranslationAction.java 0.00% 9 Missing ⚠️
...crowdin/cli/commands/actions/FileUploadAction.java 0.00% 8 Missing ⚠️
...in/cli/commands/actions/DistributionAddAction.java 0.00% 6 Missing ⚠️
...owdin/cli/commands/actions/PreTranslateAction.java 0.00% 6 Missing ⚠️
.../com/crowdin/cli/properties/PropertiesBuilder.java 14.29% 6 Missing ⚠️
.../crowdin/cli/commands/actions/StringAddAction.java 20.00% 4 Missing ⚠️
...cli/commands/actions/UploadTranslationsAction.java 0.00% 4 Missing ⚠️
...n/cli/commands/actions/ScreenshotUploadAction.java 0.00% 3 Missing ⚠️
... and 13 more
Additional details and impacted files
@@              Coverage Diff              @@
##             next-v4     #785      +/-   ##
=============================================
- Coverage      65.45%   65.27%   -0.18%     
- Complexity      1466     1468       +2     
=============================================
  Files            220      221       +1     
  Lines           6017     6040      +23     
  Branches         896      887       -9     
=============================================
+ Hits            3938     3942       +4     
- Misses          1596     1611      +15     
- Partials         483      487       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar added this to the v4 milestone May 13, 2024
@andrii-bodnar andrii-bodnar merged commit 6dd7705 into next-v4 May 13, 2024
13 checks passed
@andrii-bodnar andrii-bodnar deleted the exit-codes branch May 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants